Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21297 )
Change subject: IMPALA-13001: Support graceful and force shutdown for impala.sh. ...................................................................... Patch Set 1: (3 comments) Thanks for putting this up! http://gerrit.cloudera.org:8080/#/c/21297/1/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/21297/1/package/bin/impala.sh@87 PS1, Line 87: counts=20 period=2 When performing a graceful shutdown, it's best for the script default waiting time to match the Impala configuration items "shutdown_grace_period_s" or "shutdown_deadline_s" (perhaps it should be extended a bit longer). http://gerrit.cloudera.org:8080/#/c/21297/1/package/bin/impala.sh@106 PS1, Line 106: exit 1 nit: Perhaps we don't need to be too strict, that is, after echo warning message, we still can stop the statestored or catalogd in the usual way. http://gerrit.cloudera.org:8080/#/c/21297/1/package/bin/impala.sh@262 PS1, Line 262: options: same as start command It needs to be updated. -- To view, visit http://gerrit.cloudera.org:8080/21297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7743234952ba6b12694ecc68a920d59fea0d4ba Gerrit-Change-Number: 21297 Gerrit-PatchSet: 1 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 15 Apr 2024 02:31:10 +0000 Gerrit-HasComments: Yes
