Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21297 )
Change subject: IMPALA-13001: Support graceful and force shutdown for impala.sh ...................................................................... Patch Set 5: (4 comments) > Patch Set 4: > > (4 comments) so careful~ http://gerrit.cloudera.org:8080/#/c/21297/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21297/4//COMMIT_MSG@7 PS4, Line 7: > nit: remove period at the end Done http://gerrit.cloudera.org:8080/#/c/21297/4/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/21297/4/package/bin/impala.sh@176 PS4, Line 176: >&2 u > add ">&2 " ? Done http://gerrit.cloudera.org:8080/#/c/21297/4/package/bin/impala.sh@189 PS4, Line 189: ${IMPALA_HOME}/sbin/${service} \ > Can we print a message about the redirection? E.g. Done http://gerrit.cloudera.org:8080/#/c/21297/4/package/bin/impala.sh@213 PS4, Line 213: riod} > add ">&2 " ? Done -- To view, visit http://gerrit.cloudera.org:8080/21297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7743234952ba6b12694ecc68a920d59fea0d4ba Gerrit-Change-Number: 21297 Gerrit-PatchSet: 5 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Sun, 16 Jun 2024 09:13:29 +0000 Gerrit-HasComments: Yes
