Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 )
Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@148 PS4, Line 148: return new TColumnValue().setString_val( We should probably just call the setTimestamp_val() and not set the string val? -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Wed, 14 Feb 2024 21:52:39 +0000 Gerrit-HasComments: Yes
