gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 )
Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21015/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21015/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-12815: Support timestamp for scan predicates > Much cleaner to create a separate JIRA for timestamp support Created a separate jira: IMPALA-12815 http://gerrit.cloudera.org:8080/#/c/21015/2//COMMIT_MSG@10 PS2, Line 10: The timestamp is of the ISO 8601 format(SQL standard): > We should be more specific here, we're only talking about SCAN predicates h Done. Updated the commit message about timestamp format ISO 8601 (sql standard) http://gerrit.cloudera.org:8080/#/c/21015/2//COMMIT_MSG@14 PS2, Line 14: Testing: > Would be good to be more specific about what kind of tests: e2e, unit, cust specified custom cluster tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Wed, 14 Feb 2024 21:40:17 +0000 Gerrit-HasComments: Yes
