Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 )
Change subject: IMPALA-12503 PART-2: Support timestamp for predicates for external data source table ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/21015/2/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/2/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@145 PS2, Line 145: timestamp_col = ((TimestampLiteral) expr).toSql(); rename timestamp_col to timestampVal call getStringValue() to avoid extract the substring. String timestampVal = ((TimestampLiteral) expr).getStringValue(); Impala timestamp in string format is 'yyyy-mm-dd hh:mm:ss.ms'. Are you sure if all other databases have same format? If one database has different format, it's hard to convert from one string format to another string format. http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test File testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test: http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test@174 PS2, Line 174: 2009-01-02 00:12:00.460000000 Timestamp can consist of just the date, or just the time, with or without the fractional second portion. Please add test cases without milli seconds, without time, etc. http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test@278 PS2, Line 278: remove extra space http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test File testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test: http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test@408 PS2, Line 408: remove extra space http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test File testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test: http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test@408 PS2, Line 408: remove extra space -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 2 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 14 Feb 2024 08:54:44 +0000 Gerrit-HasComments: Yes
