Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20491 )
Change subject: IMPALA-12443: Add catalog timeline for all DDL profiles ...................................................................... Patch Set 13: Code-Review+2 (4 comments) Great work! LGTM! http://gerrit.cloudera.org:8080/#/c/20491/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20491/12//COMMIT_MSG@31 PS12, Line 31: Example > The REFRESH command is executed when the table is in unloaded state (Incomp That's clearer, thanks. http://gerrit.cloudera.org:8080/#/c/20491/12/be/src/exec/catalog-op-executor.cc File be/src/exec/catalog-op-executor.cc: http://gerrit.cloudera.org:8080/#/c/20491/12/be/src/exec/catalog-op-executor.cc@125 PS12, Line 125: catalog_profile_ = make_unique<TRuntimeProfileNode>(exec_response_->profile); > It's possible that we get a very long timeline for global INVALIDATE METADA I see, thanks for the explanation! http://gerrit.cloudera.org:8080/#/c/20491/12/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/20491/12/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2014 PS12, Line 2014: MetastoreShim.m > "table metadata" might be misunderstood as the HMS table object which conta Ah, I see, now I'm fine with either. http://gerrit.cloudera.org:8080/#/c/20491/12/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20491/12/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1514 PS12, Line 1514: } > Maybe we can use a better name unless the above codes won't invoke any exte How about "Iceberg operations are prepared for commit"? -- To view, visit http://gerrit.cloudera.org:8080/20491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbceefaeb24c66eb1a064c449d6f56077ea347c5 Gerrit-Change-Number: 20491 Gerrit-PatchSet: 13 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 03 Jan 2024 19:09:42 +0000 Gerrit-HasComments: Yes
