Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20491 )
Change subject: IMPALA-12443: Add catalog timeline for all DDL profiles ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/20491/11/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20491/11/be/src/service/client-request-state.cc@854 PS11, Line 854: lock_guard<mutex> l(lock_); > In ExecDdlRequestImpl() and UpdateTableAndColumnStats(), AddEventSequence() Oops, we should put this before UpdateQueryStatus(). Nice catch! http://gerrit.cloudera.org:8080/#/c/20491/11/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20491/11/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2690 PS11, Line 2690: int kudu_table_reserve_seconds, EventSequence catalogTimeline) > line too long (93 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/20491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbceefaeb24c66eb1a064c449d6f56077ea347c5 Gerrit-Change-Number: 20491 Gerrit-PatchSet: 12 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 15 Dec 2023 12:57:53 +0000 Gerrit-HasComments: Yes
