Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20491 )
Change subject: IMPALA-12443: Add catalog timeline for all DDL profiles ...................................................................... Patch Set 11: (1 comment) Overall LGTM, this will be helpful for analyzing DDL performance and issues, I just have one small question. http://gerrit.cloudera.org:8080/#/c/20491/11/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20491/11/be/src/service/client-request-state.cc@854 PS11, Line 854: summary_profile_->AddEventSequence(catalog_timeline.name, catalog_timeline); In ExecDdlRequestImpl() and UpdateTableAndColumnStats(), AddEventSequence() is placed before UpdateQueryStatus(). Why is it placed after here? Could this result in the loss of some events in case of an error? -- To view, visit http://gerrit.cloudera.org:8080/20491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbceefaeb24c66eb1a064c449d6f56077ea347c5 Gerrit-Change-Number: 20491 Gerrit-PatchSet: 11 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 15 Dec 2023 10:29:18 +0000 Gerrit-HasComments: Yes
