@deevroman commented on this pull request.
> +<% soft_anonymous_notes_limit_reached = !current_user &&
> @anonymous_notes_count >= 5
+ anonymous_notes_limit_reached = !current_user && @anonymous_notes_count >=
10
+ warn_class = anonymous_notes_limit_reached ? "alert-danger" :
"alert-warning" %>
> Also I would rename the "normal" limit as hard_
Agreed. Corrected.
> I think this section is a bit too much code for a template. How about moving
> these to helpers?
I'm not a Ruby developer, so the code organization example was helpful. I
suspect you're talking about creating an additional file, and it seems to me
there's not much logic that can be moved to a separate file yet.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6593#discussion_r2598999576
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6593/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
