@pablobm commented on this pull request.
> <div class="note">
<p class="alert alert-info"><%= t(".intro") %></p>
<% if !current_user %>
- <div class="alert alert-warning pb-0">
+ <div class="alert <%= warn_class %> pb-0">
I think I can work with `warn_class` being inlined, and the other two being
made into helpers.
```suggestion
<div class="alert <%= hard_anonymous_notes_limit_reached ? "alert-danger" :
"alert-warning" %> pb-0">
```
You don't need to create a new file for the helpers, you can put them in
`app/helpers/note_helper.rb`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6593#pullrequestreview-3556719993
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6593/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
