### Description

I am justifying this PR based on renewed interest in forum posts on this topic 
starting in the fall of this year 
https://community.openstreetmap.org/t/we-dont-need-anonymous-notes/105335/128 
as well as from personal experience of resolving notes

1. After 10 notes, the create notes form hides and the warning is repainted red

<img width="60%" 
src="https://github.com/user-attachments/assets/de860bad-a682-4751-b0b5-40e1742760f1"
 />

2. The previous warning is displayed after 5 anonymous notes

3. I reduced the lifetime of cookies that count anonymous notes to two weeks to 
compensate for the limit a little

### How has this been tested?

Manual testing, as well as adding a new autotest 

### Explanation

Yes, the API is still not protected. Yes, you can open a private window. 

But at least it will stop stupid robots, and it will also stop some users who 
use notes for other purposes faster. It is also a small stick in the wheels of 
lazy vandals.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6593

-- Commit Summary --

  * stricter restrictions on creating anonymous notes

-- File Changes --

    M app/assets/javascripts/index/new_note.js (2)
    M app/views/notes/new.html.erb (10)
    M test/system/create_note_test.rb (46)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6593.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6593.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6593
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to