tomhughes left a comment (openstreetmap/openstreetmap-website#6564)
> it's `current_user&.administrator?` that is the problem. In this test, the
> administrator is the current user. The target user is suspended, so it's not
> `visible?` and only an administrator can see the heatmap, therefore a
> `current_user` is required
That uses safe navigation so it won't fail in itself if `current_user` is not
defined though. It will however fail while rendering the view as does anything
else that doesn't generate the heatmap data.
I've now opened #6591 to deal with that properly by 404ing requests for
unavailable heatmaps.
Given that can we remove the attempted fix from this PR and then I'm happy to
merge it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6564#issuecomment-3613269269
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6564/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
