pablobm left a comment (openstreetmap/openstreetmap-website#6564)
@tomhughes - Re: ability to suspend confirmed users, that makes sense. I have
added a commit at the start to remove this restriction. A couple of notes:
- As a side effect, a test was creating 50 notes for a user, then confirming
them. The removal of the restriction triggers a spam suspension and resulting
in failure. I have worked around this by changing the factory, to avoid this
happening in other cases. But perhaps this is a bit heavy handed and implicit?
Let me know what you think.
- I have removed `suspend_if_possible!`, but now I'm thinking it might still be
necessary. The user listing offers a couple of footguns to suspend already
suspended users, which would raise an exception. I'm thinking of reinstating
`suspend_if_possible!`. Thoughts?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6564#issuecomment-3611594959
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6564/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
