> As for the next steps, I’m not sure whether it’s better to get this PR merged
> as is and refactor later when the notes move to standard pagination, or if we
> should address the pagination issue on user note pages first and then
> refactor this PR accordingly.
You can make a pull request that just adds the status filter. That doesn't
depend on pagination and shouldn't tank the performance because:
- status is checked anyway to see if the note is not hidden
- we're doing a similar thing in the api
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5255#issuecomment-2419119591
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5255/c2419119...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
