Matt Sergeant wrote: > > > I find that "Unknown" as a value for remote_host looks more reasonable > > than NXDOMAIN and the other values. > > Why? That's less information. Unknown for NXDOMAIN always made sense. > But "Unknown" in the case of a DNS timeout or a failure never made > sense to me.
It is less information, but is not a surprising behavior for someone who used MTAs like postfix and sendmail, which use "[remote_ip]" in case there is no reverse entry or in case of DNS failures. Also, the description of remote_host method from Qpsmtpd::Connection doesn't mention anything about remote_host being something different than the reverse DNS lookup. > Wow, that seems MUCH worse to me - to have the logs *not* storing the > dns failure reason seems completely at odds to me with what logs > should be for. OK, maybe it should be the other way around: the Received headers do not contain the DNS failure error code and the logs record them. > I think we need more consensus on this patch. Due to the objections expressed so far I reverted the change. Should I mention the overloaded meaning of remote_host in the pod?
