On 2-Jun-08, at 5:55 PM, Radu Greab wrote:

Matt Sergeant wrote:

Why not leave it as NXDOMAIN or SERVFAIL or TIMEOUT in case of
errors? I find this useful in my Received headers...

I didn't know that you coded it that way on purpose, instead it looked
to me like a thing that could be improved.

I think that remote_host should not be the error code in case of
errors. That contradicts the description of the method and may force
other people using remote_host to do their own checks.

Well on regular qmail it's set to "Unknown" in case of errors, but never tells you if the error was NXDOMAIN or SERVFAIL or TIMEOUT. I find the distinction useful.

What do you think about setting only remote_info to either the result of
a successful lookup or the error code? And remote_host will be either
the result of the successful lookup or "[$remote_ip]" in case of errors?

Possibly... What will that result in in terms of Received headers?

Matt.

Reply via email to