On 2-Jun-08, at 6:06 PM, Radu Greab wrote:
Matt Sergeant wrote:
I think that remote_host should not be the error code in case of
errors. That contradicts the description of the method and may force
other people using remote_host to do their own checks.
Well on regular qmail it's set to "Unknown" in case of errors, but
never tells you if the error was NXDOMAIN or SERVFAIL or TIMEOUT. I
find the distinction useful.
I find that "Unknown" as a value for remote_host looks more reasonable
than NXDOMAIN and the other values.
Why? That's less information. Unknown for NXDOMAIN always made sense.
But "Unknown" in the case of a DNS timeout or a failure never made
sense to me.
What do you think about setting only remote_info to either the
result of
a successful lookup or the error code? And remote_host will be
either
the result of the successful lookup or "[$remote_ip]" in case of
errors?
Possibly... What will that result in in terms of Received headers?
The Received headers won't change. Only the logs created by
logterse or
other logging plugins that use remote_host will change.
Wow, that seems MUCH worse to me - to have the logs *not* storing the
dns failure reason seems completely at odds to me with what logs
should be for.
I think we need more consensus on this patch.
Matt.
