On Wed, 18 Oct 2023 01:11, Eric Blake <ebl...@redhat.com> wrote:
static bool cluster_needs_new_alloc(BlockDriverState *bs, uint64_t
l2_entry)
{
switch (qcow2_get_cluster_type(bs, l2_entry)) {
case QCOW2_CLUSTER_NORMAL:
+ fallthrough;
case QCOW2_CLUSTER_ZERO_ALLOC:
Why is this one needed? It looks two case labels for the same code is
okay; the fallthrough attribute is only needed once a case label is no
lonter empty.
...
These two also look spurious.
...
but these three seem spurious.
Thanks for pointing it out, Eric. Indeed these are mistakes.
By the way, there's a newer version posted [0] because as you noticed I
accidentally left --function-context on git-format-patch and didn't
notice that some of them blew up in size.
Also, the consensus in v1 was to reject this patch series in general
[1].
[0]: <cover.1697186560.git.manos.pitsidiana...@linaro.org>
https://lore.kernel.org/qemu-devel/cover.1697186560.git.manos.pitsidiana...@linaro.org/
[1]:
<cafeaca_flbe9cuwfypeuejj8dcerhftpnx+ivavfvh4sxx1...@mail.gmail.com>
https://lore.kernel.org/qemu-devel/cafeaca_flbe9cuwfypeuejj8dcerhftpnx+ivavfvh4sxx1...@mail.gmail.com/
--
Manos
