Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension

[Richard Henderson]

On 1/24/23 09:59, Christoph Muellner wrote:

+static bool trans_th_sfence_vmas(DisasContext *ctx, arg_th_sfence_vmas *a)
+{
+    (void) a;
+    REQUIRE_XTHEADSYNC(ctx);
+
+#ifndef CONFIG_USER_ONLY
+    REQUIRE_PRIV_MS(ctx);
+    decode_save_opc(ctx);
+    gen_helper_tlb_flush_all(cpu_env);

Why are you using decode_save_opc() when helper_tlb_flush_all() cannot raise an 
exception?


r~