On 22 December 2011 18:20, Mark Langsdorf <mark.langsd...@calxeda.com> wrote: > From: Rob Herring <rob.herr...@calxeda.com> > > Add support for ahci on sysbus.
Again, IDE isn't my domain, but some minor points: > +typedef struct PlatAHCIState { > + SysBusDevice busdev; > + AHCIState ahci; > +} PlatAHCIState; Indentation is wrong here. > +static SysBusDeviceInfo plat_ahci_info[] = { > + { > + .qdev.name = "plat-ahci", > + .qdev.size = sizeof(PlatAHCIState), > + .init = plat_ahci_init, > + },{ > + /* end of list */ > + } > +}; > + > +static void plat_ahci_register(void) > +{ > + sysbus_register_withprop(plat_ahci_info); > +} sysbus_register_withprop() takes a single SysBusDeviceInfo, not a list. -- PMM