On Fri, Sep 16, 2022 at 14:15 Ani Sinha <a...@anisinha.ca> wrote: > > > On Fri, Sep 16, 2022 at 14:08 Daniel P. Berrangé <berra...@redhat.com> > wrote: > >> On Fri, Sep 16, 2022 at 01:51:14PM +0530, Ani Sinha wrote: >> > On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster <arm...@redhat.com> >> wrote: >> > > >> > > Ani Sinha <a...@anisinha.ca> writes: >> > > >> > > > On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster < >> arm...@redhat.com> wrote: >> > > >> >> > > >> The has_FOO for pointer-valued FOO are redundant, except for >> arrays. >> > > >> They are also a nuisance to work with. Recent commit "qapi: Start >> to >> > > >> elide redundant has_FOO in generated C" >> > > > >> > > > Commit is referenced using <commit hash 13 chars min> ("commit >> header") >> > > >> > > Apply my patches in your tree, and your hashes will differ from mine. >> > > Hashes can serve as stable reference only when we git-fetch patches, >> not >> > > when we git-send-email then. >> > >> > Has the referenced patch not been pushed upstream already? I thought >> > it was and hence was asking for the reference. >> >> Err, it is just a few patches earlier in this very series you're >> looking at. > > > Hmm ok. It’s missing from my inbox. Probably was not CC’d to me. >
Indeed. https://lore.kernel.org/all/20220915204317.3766007-5-arm...@redhat.com/ >