On Mon, Jun 13, 2022 at 1:53 PM Richard Henderson <
richard.hender...@linaro.org> wrote:
> On 6/12/22 13:48, Warner Losh wrote:
> > Signed-off-by: Stacey Son <s...@freebsd.org>
> > Signed-off-by: Warner Losh <i...@bsdimp.com>
> > ---
> > bsd-user/bsd-file.h | 14 ++++++++++++++
> > bsd-user/freebsd/os-syscall.c | 8 ++++++++
> > 2 files changed, 22 insertions(+)
> >
> > diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h
> > index 500d6ba78b9..73263ba482f 100644
> > --- a/bsd-user/bsd-file.h
> > +++ b/bsd-user/bsd-file.h
> > @@ -491,4 +491,18 @@ static abi_long do_bsd___getcwd(abi_long arg1,
> abi_long arg2)
> > return get_errno(ret);
> > }
> >
> > +/* dup(2) */
> > +static abi_long do_bsd_dup(abi_long arg1)
> > +{
> > +
> > + return get_errno(dup(arg1));
> > +}
> > +
> > +/* dup2(2) */
> > +static abi_long do_bsd_dup2(abi_long arg1, abi_long arg2)
> > +{
> > +
> > + return get_errno(dup2(arg1, arg2));
> > +}
>
> Extra lines. Is this some setting in your editor? Otherwise,
>
It's an odd quirk of FreeBSD's style from the 90s until 2020... I'm totally
blind to
it most of the time...
> Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
>
Thanks for this, and all the other reviews.
Warner
