On Fri, 13 May 2022 at 19:16, <marcandre.lur...@redhat.com> wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > Used in the next patch, to simplify qga code. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > include/qemu/osdep.h | 1 + > util/osdep.c | 10 ++++++++-- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > index 67cc465416..64f51cfb7a 100644 > --- a/include/qemu/osdep.h > +++ b/include/qemu/osdep.h > @@ -489,6 +489,7 @@ void sigaction_invoke(struct sigaction *action, > */ > int qemu_open_old(const char *name, int flags, ...); > int qemu_open(const char *name, int flags, Error **errp); > +int qemu_open_cloexec(const char *name, int flags, mode_t mode, Error > **errp); > int qemu_create(const char *name, int flags, mode_t mode, Error **errp); > int qemu_close(int fd); > int qemu_unlink(const char *name);
Where we make a function global and put it in a header we should generally add a documentation comment describing it, please. thanks -- PMM
