marcandre.lur...@redhat.com writes: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > The function takes care of setting CLOEXEC, and reporting error. > > The reported error message will differ, from: > "failed to open file 'foo' (mode: 'r')" > to: > "Failed to open file 'foo'" > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
I don't like the first message's "(mode: 'r')", because it talks code to the user. Better: "for reading". I'm not sure how useful the "for reading" bit of information is here. You decide. Reviewed-by: Markus Armbruster <arm...@redhat.com>
