On Tue, Apr 5, 2022, 4:51 AM Kashyap Chamarthy <kcham...@redhat.com> wrote:
> On Mon, Apr 04, 2022 at 02:56:10PM -0400, John Snow wrote:
> > On Mon, Apr 4, 2022 at 2:54 PM John Snow <js...@redhat.com> wrote:
>
> [...]
>
> > > > > .gitignore | 2 +-
> > > > > Makefile | 16 ++++++++--------
> > > > > setup.cfg | 24 +-----------------------
> > > > > setup.py | 2 +-
> > > > > 4 files changed, 11 insertions(+), 33 deletions(-)
> > > >
> > > > The changes here look fine to me (and thanks for making it a "micro
> > > > change"). I'll let sharper eyes than mine to give a closer look at
> the
> > > > `git filter-repo` surgery. Although, that looks fine to me too.
> > > >
> > > > [...]
> > > >
> > > > > .PHONY: distclean
> > > > > distclean: clean
> > > > > - rm -rf qemu.egg-info/ .venv/ .tox/ $(QEMU_VENV_DIR) dist/
> > > > > + rm -rf qemu.qmp.egg-info/ .venv/ .tox/ $(QEMU_VENV_DIR) dist/
> > > > > rm -f .coverage .coverage.*
> > > > > rm -rf htmlcov/
> > > > > diff --git a/setup.cfg b/setup.cfg
> > > > > index e877ea5..4ffab73 100644
> > > > > --- a/setup.cfg
> > > > > +++ b/setup.cfg
> > > > > @@ -1,5 +1,5 @@
> > > > > [metadata]
> > > > > -name = qemu
> > > > > +name = qemu.qmp
> > > > > version = file:VERSION
> > > > > maintainer = QEMU Developer Team
> > > >
> > > > In the spirit of patch 04 ("update maintainer metadata"), do you also
> > > > want to update here too? s/QEMU Developer Team/QEMU Project?
> > > >
> > >
> > > Good spot.
> >
> > ...Or, uh. That's exactly what I update in patch 04. Are you asking me
> > to fold in that change earlier? I'm confused now.
>
> Oops, perils of reviewing late in the day. I missed to notice it's the
> same file. You're right; please ignore my remark. Sorry for the noise.
>
I made the same mistake upon reading the feedback, so we're both guilty 😅
Thanks Kashyap, I appreciate the review.
There's three more series here to apply to the new forked package (not yet
re-sent to the ML):
(2) Adding GitLab CI configuration. Not relevant for you, probably.
(3) Adding Sphinx documentation. This builds jsnow.gitlab.io/qemu.qmp/ -
I'd be appreciative of your feedback on this. I'm interested both in
proofreading and in design feedback here. All comments welcome.
[Though more rigorous changes to the design might be a "later" thing, but
the feedback is welcomed all the same.]
(4) Adding automatic package builds and git-based versioning to GitLab.
Maybe also not too relevant for you. 🙂
>
>
> --
> /kashyap
>
Thanks for your time!
