On Mon, Apr 4, 2022 at 2:54 PM John Snow <js...@redhat.com> wrote:
>
> On Fri, Apr 1, 2022 at 1:05 PM Kashyap Chamarthy <kcham...@redhat.com> wrote:
> >
> > On Wed, Mar 30, 2022 at 02:24:13PM -0400, John Snow wrote:
> > > Split python/ from qemu.git, using these commands:
> > >
> > > > git subtree split -P python/ -b python-split-v3
> > > > mkdir ~/src/tmp
> > > > cd ~/src/tmp
> > > > git clone --no-local --branch python-split-v3 --single-branch ~/src/qemu
> > > > cd qemu
> > > > git filter-repo --path qemu/machine/ \
> > > --path qemu/utils/ \
> > > --path tests/iotests-mypy.sh \
> > > --path tests/iotests-pylint.sh \
> > > --invert-paths
> > >
> > > This commit, however, only performs some minimum cleanup to reflect the
> > > deletion of the other subpackages. It is not intended to be exhaustive,
> > > and further edits are made in forthcoming commits.
> > >
> > > These fixes are broken apart into micro-changes to facilitate mailing
> > > list review subject-by-subject. They *could* be squashed into a single
> > > larger commit on merge if desired, but due to the nature of the fork,
> > > bisectability across the fork boundary is going to be challenging
> > > anyway. It may be better value to just leave these initial commits
> > > as-is.
> > >
> > > Signed-off-by: John Snow <js...@redhat.com>
> > > ---
> > > .gitignore | 2 +-
> > > Makefile | 16 ++++++++--------
> > > setup.cfg | 24 +-----------------------
> > > setup.py | 2 +-
> > > 4 files changed, 11 insertions(+), 33 deletions(-)
> >
> > The changes here look fine to me (and thanks for making it a "micro
> > change"). I'll let sharper eyes than mine to give a closer look at the
> > `git filter-repo` surgery. Although, that looks fine to me too.
> >
> > [...]
> >
> > > .PHONY: distclean
> > > distclean: clean
> > > - rm -rf qemu.egg-info/ .venv/ .tox/ $(QEMU_VENV_DIR) dist/
> > > + rm -rf qemu.qmp.egg-info/ .venv/ .tox/ $(QEMU_VENV_DIR) dist/
> > > rm -f .coverage .coverage.*
> > > rm -rf htmlcov/
> > > diff --git a/setup.cfg b/setup.cfg
> > > index e877ea5..4ffab73 100644
> > > --- a/setup.cfg
> > > +++ b/setup.cfg
> > > @@ -1,5 +1,5 @@
> > > [metadata]
> > > -name = qemu
> > > +name = qemu.qmp
> > > version = file:VERSION
> > > maintainer = QEMU Developer Team
> >
> > In the spirit of patch 04 ("update maintainer metadata"), do you also
> > want to update here too? s/QEMU Developer Team/QEMU Project?
> >
>
> Good spot.
...Or, uh. That's exactly what I update in patch 04. Are you asking me
to fold in that change earlier? I'm confused now.
--js
