Re: [PATCH v3 1/3] qmp: Support for querying stats

[Mark Kanda]

On 2/1/2022 6:08 AM, Daniel P. Berrangé wrote:
+##
+# @StatsResults:
+#
+# Target specific results.
+#
+# Since: 7.0
+##
+{ 'union': 'StatsResults',
+  'base': { 'target': 'StatsTarget' },
+  'discriminator': 'target',
+  'data': { 'vcpu': 'VCPUStatsResults',
+            'vm': 'VMStatsResults' } }
I feel we can simplify this all down somewhat, eliminating levels
of redundant nesting
{ 'struct': 'StatsResultsEntry',
   'data': { '*kvm': [ 'Stats' ] } }

{ 'struct': 'StatsResultsVCPUEntry',
   'base': 'StatsResultsEntry',
   'data': 'path': 'str' } }

{ 'struct': 'StatsResults',
   'data': {
       '*vcpus': ['StatsResultsVCPUEntry'],
       '*vm': 'StatsResultsEntry'
   }
}



I'm happy to make this change, but I would like Paolo to comment as he had 
suggested the StatsResults layout [1].

Thanks Daniel/Paolo,
-Mark

[1] https://lore.kernel.org/all/ee0d6990-06f3-9a1b-f7d5-7c379f0e9...@redhat.com/