Thanks Daniel,

On 2/1/2022 6:08 AM, Daniel P. Berrangé wrote:
+#
+# Since: 7.0
+##
+{ 'enum' : 'StatType',
+  'data' : [ 'cumulative', 'instant', 'peak',
+             'linear-hist', 'log-hist', 'unknown' ] }
IMHO 'unknown' shouldn't exist at all.


I added the 'unknown' member here (and in other enums) to handle situations where QEMU is behind KVM in terms of enumerating the various stat types, units, etc. I feel this will be a semi-common scenario (old QEMU on a new kernel) and with 'unknown', QEMU can at least display the raw data.

That said, I happy skip 'unknown' entries if you think that's better.

Thanks/regards,
-Mark

Reply via email to