On 3/24/21 11:35 PM, Richard Henderson wrote: > On 3/23/21 9:46 AM, Claudio Fontana wrote: >> target/arm/kvm-stub.c | 24 ------------------------ > > Can you really get rid of this?
calls in machine.c are protected by if (kvm_enabled()), so as long as the proto is in sight we can remove those. Futher refactoring of kvm/tcg for machines could improve this further (we still have it mixed on x86 too). > If so, I think this should be a separate step. Ok, can split up, Claudio > > >> --- a/target/arm/kvm/meson.build >> +++ b/target/arm/kvm/meson.build >> @@ -1,3 +1,8 @@ >> arm_ss.add(when: 'CONFIG_TCG', if_false: files( >> 'helper-stubs.c', >> )) >> + >> +arm_ss.add(when: 'CONFIG_KVM', if_true: files( >> + 'kvm.c', >> + 'kvm64.c', >> +)) >> \ No newline at end of file > > Watch the whitespace warnings. > > > r~ >
