On Fri, Feb 12, 2021 at 06:38:16PM +0000, Peter Maydell wrote: > On Thu, 11 Feb 2021 at 10:12, Gerd Hoffmann <kra...@redhat.com> wrote: > > > > Hi, > > > > > I notice that as well as handling surface_bits_per_pixel() > > > possibly returning 8, 15, 16, 24, these devices also seem to > > > check for the possibility it returns 0 (presumably meaning > > > "no surface" or "no surface yet" ?). > > > > Depends a bit on how the surface is created. > > > > When using host memory as backing storage (typical workflow is > > qemu_console_resize() + qemu_console_surface() calls) bits per pixel is > > 32 no matter what (format is PIXMAN_x8r8g8b8 to be exact). I think this > > is true for most if not all arm display devices. > > Quick follow-up check: this is always RGB, ie is_surface_bgr() > will always return false, right ?
Yes, always rgb (in host native byte order). take care, Gerd
