On 2/11/21 12:25 PM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20210210234334.3750022-1-f4...@amsat.org/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20210210234334.3750022-1-f4...@amsat.org > Subject: [RFC PATCH] target/mips/cp0_timer: Use new clock_ns_to_ticks() > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 86c0e95 target/mips/cp0_timer: Use new clock_ns_to_ticks() > > === OUTPUT BEGIN === > ERROR: space prohibited after that '-' (ctx:ExW) > #39: FILE: target/mips/cp0_timer.c:41: > + - (uint32_t)(now_ticks / cpu->cp0_count_rate); > ^
Well, having the operator at the beginning of the line makes it more obvious than having it at the end of the previous line. I can remove the space to make checkpatch happy but it seems wrong.
