On 01/11/21 11:07, Christian Borntraeger wrote: > > > On 11.01.21 11:05, Laszlo Ersek wrote: >> On 01/11/21 10:46, Christian Borntraeger wrote: >>> >>> >>> On 04.01.21 14:24, Laszlo Ersek wrote: >>>> virtio-fs qualifies as a bootable device minimally under OVMF, but >>>> currently the necessary "bootindex" property is missing (fw_cfg kernel >>>> boot notwithstanding). >>>> >>>> Add the property. For completeness, add it to the CCW device as well; >>>> other virtio-ccw devices seem to have "bootindex" properties too. >>> >>> Currently we do not have boot support for virtiofs on s390x (ccw) >>> Not sure if it is better if we should add the property now or whenever >>> boot support is implemented. >>> As of today we do have bootindex for block and net. Maybe it is better >>> to defer bootindex for virtio-fs-ccw until we can boot from it? In >>> that way management software can detect if this is bootable or not? >> >> Sure, I can drop the "vhost-user-fs-ccw.c hunk". >> >> (I guess I could even lift the property itself (replacing the alias) to >> "vhost-user-fs-pci.c", for now -- what's everyone's take on that?) > > Keep it as is. This would simplify a later addition to ccw. >
Thanks! I'll wait for some feedback from the other reviewers, before posting v2. Laszlo
