On Mon, 4 Jan 2021 14:24:01 +0100 Laszlo Ersek <ler...@redhat.com> wrote:
> virtio-fs qualifies as a bootable device minimally under OVMF, but > currently the necessary "bootindex" property is missing (fw_cfg kernel > boot notwithstanding). > > Add the property. For completeness, add it to the CCW device as well; > other virtio-ccw devices seem to have "bootindex" properties too. > > Example OpenFirmware device path for the "vhost-user-fs-pci" device in the > "bootorder" fw_cfg file: > > /pci@i0cf8/pci-bridge@1,6/pci1af4,105a@0/filesystem@0 > > Cc: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Christian Borntraeger <borntrae...@de.ibm.com> > Cc: Cornelia Huck <coh...@redhat.com> > Cc: Halil Pasic <pa...@linux.ibm.com> > Cc: Stefan Hajnoczi <stefa...@redhat.com> > Cc: qemu-s3...@nongnu.org > Cc: virtio...@redhat.com > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > include/hw/virtio/vhost-user-fs.h | 1 + > hw/s390x/vhost-user-fs-ccw.c | 2 ++ > hw/virtio/vhost-user-fs-pci.c | 2 ++ > hw/virtio/vhost-user-fs.c | 10 ++++++++++ > 4 files changed, 15 insertions(+) > I agree that you should just drop the ccw hunk for now. The rest of the patch looks good to me.
