To be frank, I'm disappointed the code passed review in this state. There are excuses for each of the issues addressed in this series (PATCH 1 naming is hard, PATCH 2 recognizing non-local relations is hard, PATCH 3 mistakes on error paths are easy to miss, PATCH 4 can't expect all reviewers to know "no more simple unions, please"). Still, having so many of them escape notice is disappointing.
Please review. Markus Armbruster (4): qga: Rename guest-get-devices return member 'address' to 'id' qga: Use common time encoding for guest-get-devices 'driver-date' qga-win: Fix guest-get-devices error API violations qga: Flatten simple union GuestDeviceId qga/qapi-schema.json | 29 +++++++++++++++++++---------- qga/commands-win32.c | 39 ++++++++++++++++++++------------------- 2 files changed, 39 insertions(+), 29 deletions(-) -- 2.26.2
