Philippe Mathieu-Daudé <phi...@redhat.com> writes: > On 10/21/20 9:15 AM, Markus Armbruster wrote: >> Member 'address' is union GuestDeviceAddress with a single branch >> GuestDeviceAddressPCI, containing PCI vendor ID and device ID. This >> is not a PCI address. Type GuestPCIAddress is. Messed up in recent >> commit 2e4211cee4 "qga: add command guest-get-devices for reporting >> VirtIO devices". > > Out of curiosity, how did you notice?
I searched for simple unions to remind myself of the size of that problem, and found a new one, i.e. a problem I can still avoid. I started to do PATCH 4, and noticed the other issues. > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Thanks!
