On Tue, Sep 22, 2020 at 05:00:47PM -0400, John Snow wrote:
> The edge case is that if the name is '', this expression returns a
> string instead of a bool, which violates our declared type.
>
> Signed-off-by: John Snow <js...@redhat.com>
> ---
> scripts/qapi/gen.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
> index 9898d513ae..cb2b2655c3 100644
> --- a/scripts/qapi/gen.py
> +++ b/scripts/qapi/gen.py
> @@ -251,7 +251,7 @@ def __init__(self, prefix, what, user_blurb,
> builtin_blurb, pydoc):
>
> @staticmethod
> def _is_user_module(name):
> - return name and not name.startswith('./')
> + return name is not None and not name.startswith('./')
This changes behavior if name=='', and I guess this is OK, but
I'm not sure. I miss documentation on `visit_module()`,
`visit_include()`, and `_is_user_module()`. I don't know what
`name` means here, and what is a "user module".
>
> @staticmethod
> def _is_builtin_module(name):
> --
> 2.26.2
>
--
Eduardo
