On 9/23/20 9:42 AM, Cleber Rosa wrote:
On Tue, Sep 22, 2020 at 05:00:30PM -0400, John Snow wrote:
Using `pylint --generate-rcfile > pylintrc`, generate a skeleton
pylintrc file. Sections that are not presently relevant (by the end of
this series) are removed leaving just the empty section as a search
engine / documentation hint to future authors.
Right now, quite a few modules are ignored as they are known to fail as
of this commit. modules will be removed from the known-bad list
throughout this and following series as they are repaired.
Note: Normally, pylintrc would go in the folder above the module, but as
that folder is shared by many things, it is going inside the module
folder (for now). Due to a bug in pylint 2.5.x, pylint does not
correctly recognize when it is being run from "inside" a package, and
must be run *outside* of the package.
Therefore, to run it, you must:
> pylint scripts/qapi/ --rcfile=scripts/qapi/pylintrc
Signed-off-by: John Snow <js...@redhat.com>
One concern I have here is that the pylint version is not defined.
Based on experience, different pylint will behave differently, because
among other things, it may introduce new checks.
I'd at the very least document the pylint version used in the commit
message, until a "requirements.txt"-like solution pinning a version is
given.
Other than that,
Reviewed-by: Cleber Rosa <cr...@redhat.com>
Tested-by: Cleber Rosa <cr...@redhat.com>
Alright, I'll put it in the commit message itself instead of in the
cover letter.
The next step is to re-engage on that Makefile patch that I was working
on for ./python/qemu and introduce it here too, which will document the
pinned versions correctly.
--js
