On 3/19/20 12:33 PM, Peter Maydell wrote: > The target_flat.h file is a QEMU header, so we should include it using > quotes, not angle brackets. > > Coverity otherwise is unable to find the header: > > "../linux-user/flatload.c", line 40: error #1712: cannot open source file > "target_flat.h" > #include <target_flat.h> > ^ > > because the relevant directory is only on the -iquote path, not the -I path. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > I don't know why Coverity in particular has trouble here but > real compilers don't. Still, the "" is the right thing. > --- > linux-user/flatload.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
