On 3/19/20 12:33 PM, Peter Maydell wrote: > All the Coverity-specific definitions of qemu_mutex_lock() and friends > have a trailing semicolon. This works fine almost everywhere because > of QEMU's mandatory-braces coding style and because most callsites are > simple, but target/s390x/sigp.c has a use of qemu_mutex_trylock() as > an if() statement, which makes the ';' a syntax error: > "../target/s390x/sigp.c", line 461: warning #18: expected a ")" > if (qemu_mutex_trylock(&qemu_sigp_mutex)) { > ^ > > Remove the bogus semicolons from the macro definitions. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > include/qemu/thread.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~