On 3/19/20 12:33 PM, Peter Maydell wrote: > For Coverity's benefit, we provide simpler versions of functions like > qemu_mutex_lock(), qemu_cond_wait() and qemu_cond_timedwait(). When > we added qemu_cond_timedwait() in commit 3dcc9c6ec4ea, a cut and > paste error meant that the Coverity version of qemu_cond_timedwait() > was using the wrong _impl function, which makes the Coverity parser > complain: > > "/qemu/include/qemu/thread.h", line 159: warning #140: too many arguments in > function call > return qemu_cond_timedwait(cond, mutex, ms); > ^ > > "/qemu/include/qemu/thread.h", line 159: warning #120: return value type does > not match the function type > return qemu_cond_timedwait(cond, mutex, ms); > ^ > > "/qemu/include/qemu/thread.h", line 156: warning #1563: function > "qemu_cond_timedwait" not emitted, consider modeling it or review > parse diagnostics to improve fidelity > static inline bool (qemu_cond_timedwait)(QemuCond *cond, QemuMutex *mutex, > ^ > > These aren't fatal, but reduce the scope of the analysis. Fix the error. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > include/qemu/thread.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
