Patchew URL: https://patchew.org/QEMU/20200317163616.30027-1-f4...@amsat.org/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/13] target: Add the Renesas RX architecture Message-id: 20200317163616.30027-1-f4...@amsat.org Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20200317200541.6246-1-phi...@redhat.com -> patchew/20200317200541.6246-1-phi...@redhat.com Switched to a new branch 'test' 3a72228 Add rx-softmmu e284aa6 target/rx: Dump bytes for each insn during disassembly 58646ca target/rx: Collect all bytes during disassembly 71dbe11 target/rx: Emit all disassembly in one prt() b9e97ae target/rx: Use prt_ldmi for XCHG_mr disassembly 25d5453 target/rx: Replace operand with prt_ldmi in disassembler 369a776 target/rx: Disassemble rx_index_addr into a string f31720a target/rx: RX disassembler f38c0ff target/rx: CPU definitions 5c907db target/rx: TCG helpers 44000a2 target/rx: TCG translation 2b9cb96 MAINTAINERS: Add entry for the Renesas RX architecture 746243f hw/registerfields.h: Add 8bit and 16bit register macros === OUTPUT BEGIN === 1/13 Checking commit 746243fada73 (hw/registerfields.h: Add 8bit and 16bit register macros) ERROR: Macros with multiple statements should be enclosed in a do - while loop #29: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #33: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 48 lines checked Patch 1/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/13 Checking commit 2b9cb96ef341 (MAINTAINERS: Add entry for the Renesas RX architecture) 3/13 Checking commit 44000a2d6936 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 3/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/13 Checking commit 5c907dbf9a1c (target/rx: TCG helpers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 4/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/13 Checking commit f38c0ffeadc7 (target/rx: CPU definitions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 total: 0 errors, 1 warnings, 706 lines checked Patch 5/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/13 Checking commit f31720a34503 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 6/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/13 Checking commit 369a77660e88 (target/rx: Disassemble rx_index_addr into a string) 8/13 Checking commit 25d5453ea0b8 (target/rx: Replace operand with prt_ldmi in disassembler) 9/13 Checking commit b9e97ae22a00 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 10/13 Checking commit 71dbe119dcf7 (target/rx: Emit all disassembly in one prt()) 11/13 Checking commit 58646ca43056 (target/rx: Collect all bytes during disassembly) 12/13 Checking commit e284aa62a67c (target/rx: Dump bytes for each insn during disassembly) 13/13 Checking commit 3a72228fc26c (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 13/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200317163616.30027-1-f4...@amsat.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com