On Wed, Nov 20, 2019 at 08:59:40AM +0100, Greg Kurz wrote: > On Wed, 20 Nov 2019 08:46:51 +0530 > Balamuruhan S <bal...@linux.ibm.com> wrote: > > > On Wed, Nov 20, 2019 at 08:31:03AM +0530, Balamuruhan S wrote: > > > On Wed, Nov 20, 2019 at 09:02:26AM +1100, David Gibson wrote: > > > > On Wed, Nov 20, 2019 at 09:00:32AM +1100, David Gibson wrote: > > > > > On Wed, Nov 20, 2019 at 08:56:18AM +1100, David Gibson wrote: > > > > > > On Tue, Nov 19, 2019 at 11:20:53PM +0530, Balamuruhan S wrote: > > > > > > > homer/occ sizes are calculated in skiboot with `(mask | 0xfffff) > > > > > > > + 1`, > > > > > > > and from xscom access should return correct mask values instead > > > > > > > of actual > > > > > > > sizes. > > > > > > > > > > > > > > Signed-off-by: Cédric Le Goater <c...@kaod.org> > > > > > > > Signed-off-by: Balamuruhan S <bal...@linux.ibm.com> > > > > > > > --- > > > > > > > hw/ppc/pnv_xscom.c | 10 ++++++---- > > > > > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > > > > > > > > > diff --git a/hw/ppc/pnv_xscom.c b/hw/ppc/pnv_xscom.c > > > > > > > index f01d788a65..cdd5fa356e 100644 > > > > > > > --- a/hw/ppc/pnv_xscom.c > > > > > > > +++ b/hw/ppc/pnv_xscom.c > > > > > > > @@ -46,6 +46,10 @@ > > > > > > > #define P9_PBA_BARMASK0 0x5012b04 > > > > > > > #define P9_PBA_BARMASK2 0x5012b06 > > > > > > > > > > > > > > +/* Mask to calculate Homer/Occ size */ > > > > > > > +#define HOMER_SIZE_MASK 0x0000000000300000ull > > > > > > > +#define OCC_SIZE_MASK 0x0000000000700000ull > > > > > > > > > > > > Uuuhhhhh... AFAICT these defines have identical values to > > > > > > PNV_HOMER_SIZE and PNV_OCC_COMMON_AREA_SIZE, so I don't see what > > > > > > this > > > > > > patch is actually changing. > > > > > > > > > > Oh, sorry, missed that the values were changed in 1/5. Would have > > > > > been easier to follow if the two patches were folded together, but > > > > > never mind. Applied. > > > > > > > > Ugh.. or not. The first patch doesn't apply for me, looks like it > > > > needs a rebase (or you have something else in your tree I don't know > > > > about). > > > > > > I checked out from upstream master (commit: 8937f17249 ) and worked on > > ^ > > | > > ignore this its my first patch commit id (1/5)---- > > > > > it. > > > > upstream commit id: f086f22d6c (VFIO fixes 2019-11-18), please let me > > know if you would like me to respin the patches after rebase with v4.2.0 > > rc2 release. > > > > Or maybe base your patches on David's ppc-for-5.0 branch available at > https://github.com/dgibson/qemu .
Thanks Greg, going forward I will base my patches on David's recent branch for the release. > > > -- Bala > > > > > > > > -- Bala > > > > > > > > -- > > > > David Gibson | I'll have my music baroque, and my > > > > code > > > > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ > > > > _other_ > > > > | _way_ _around_! > > > > http://www.ozlabs.org/~dgibson > > > > > > > > > > > >
