On 13/11/2019 12.59, Alex Bennée wrote: > While the concept of only dropping to ssh if a test fails is nice it > is more useful for this to be unconditional. You usually just want to > get the build up and running and then noodle around debugging or > attempting to replicate. > > Cc: Peter Maydell <peter.mayd...@linaro.org> > Signed-off-by: Alex Bennée <alex.ben...@linaro.org> > > --- > v2 > - fix spelling > --- > tests/vm/basevm.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py > index 91a9226026d..0b8c1b26576 100755 > --- a/tests/vm/basevm.py > +++ b/tests/vm/basevm.py > @@ -403,7 +403,7 @@ def main(vmcls): > exitcode = 0 > if vm.ssh(*cmd) != 0: > exitcode = 3 > - if exitcode != 0 and args.interactive: > + if args.interactive: > vm.ssh() > > if not args.snapshot: >
Reviewed-by: Thomas Huth <th...@redhat.com>
