Stefan Hajnoczi <stefa...@redhat.com> writes:
> From: Aarushi Mehta <mehta.aar...@gmail.com>
>
> Only enumerates option for devices that support it.
I'm not sure I get this sentence.
> Since QAPI schema
> supports io_uring, which is the actual name of the Linux API, it is
> preferred over io-uring.
I guess this one means something like "Since io_uring is the actual name
of the Linux API, we use it as enum value even though the QAPI schema
conventions would prefer io-uring."
> Signed-off-by: Aarushi Mehta <mehta.aar...@gmail.com>
> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
> ---
> qapi/block-core.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index b274aef713..3196f40178 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2851,11 +2851,13 @@
> #
> # @threads: Use qemu's thread pool
> # @native: Use native AIO backend (only Linux and Windows)
> +# @io_uring: Use linux io_uring (since 4.2)
> #
> # Since: 2.9
> ##
> { 'enum': 'BlockdevAioOptions',
> - 'data': [ 'threads', 'native' ] }
> + 'data': [ 'threads', 'native',
> + { 'name': 'io_uring', 'if': 'defined(CONFIG_LINUX_IO_URING)' } ]
> }
>
> ##
> # @BlockdevCacheOptions:
I encourage you to polish the commit message some.
Acked-by: Markus Armbruster <arm...@redhat.com>
