Am 25.10.2019 um 18:04 hat Stefan Hajnoczi geschrieben: > From: Aarushi Mehta <mehta.aar...@gmail.com> > > Signed-off-by: Aarushi Mehta <mehta.aar...@gmail.com> > Reviewed-by: Maxim Levitsky <maximlevit...@gmail.com> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > include/block/block.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/block/block.h b/include/block/block.h > index 89606bd9f8..bdb48dcd1b 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -126,6 +126,7 @@ typedef struct HDGeometry { > ignoring the format layer */ > #define BDRV_O_NO_IO 0x10000 /* don't initialize for I/O */ > #define BDRV_O_AUTO_RDONLY 0x20000 /* degrade to read-only if opening > read-write fails */ > +#define BDRV_O_IO_URING 0x40000 /* use io_uring instead of the thread > pool */
Why do we need a new (global!) flag rather than a driver-specific option for file-posix? This looks wrong to me, the flag has no sensible meaning for any other driver. (Yes, BDRV_O_NATIVE_AIO is wrong, too, but compatibility means we can't remove it easily.) Kevin