On 10/14/19 5:36 PM, Peter Maydell wrote:
On Thu, 26 Sep 2019 at 18:34, Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
The BCM2835 AUX UART is compatible with the 16650 model, when
the registers belong the the 16650 block, use its trace events,
else use bcm2835_aux_read/write.
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
---
+ if (is_16650(offset)) {
+ trace_serial_ioport_read((offset & 0x1f) >> 2, res);
+ } else {
+ trace_bcm2835_aux_read(offset, res);
+ }
I'm not really a fan of this. I would expect that if I turn
on the trace point for reads from the device that I see all
the reads, not just a subset of them. The device may be
minimally software-compatible with a 16650, but it isn't actually
a 16650, and there doesn't seem to be much point in sharing
the serial_ioport_read() tracepoint.
Yes, I posted a newer series for this device after review comments:
hw/arm/raspi: Split the UART block from the AUX block
https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01498.html
I forgot to mention here this patch was obsolete, sorry :/
