Philippe Mathieu-Daudé <f4...@amsat.org> writes:
> The BCM2835 AUX UART is compatible with the 16650 model, when > the registers belong the the 16650 block, use its trace events, > else use bcm2835_aux_read/write. My only concern here is how we surface that detail to the potential user. It's not a major thing as I assume most users of the trace points are developers so maybe... > diff --git a/hw/char/trace-events b/hw/char/trace-events > index 2ce7f2f998..a7d477ab1e 100644 > --- a/hw/char/trace-events > +++ b/hw/char/trace-events > @@ -1,5 +1,9 @@ > # See docs/devel/tracing.txt for syntax documentation. > > +# bcm2835_aux.c "(accesses to the 16650 areas are logged via the serial_ioport_write tracepoint)"? > +bcm2835_aux_read(uint64_t addr, uint32_t value) "read addr 0x%"PRIx64" value > 0x%x" > +bcm2835_aux_write(uint64_t addr, uint32_t value) "read addr 0x%"PRIx64" > value 0x%x" > + > # parallel.c > parallel_ioport_read(const char *desc, uint16_t addr, uint8_t value) "read > [%s] addr 0x%02x val 0x%02x" > parallel_ioport_write(const char *desc, uint16_t addr, uint8_t value) "write > [%s] addr 0x%02x val 0x%02x" Otherwise: Reviewed-by: Alex Bennée <alex.ben...@linaro.org> -- Alex Bennée
