On 05.08.19 17:33, Max Reitz wrote: > In write-blocking mode, all writes to the top node directly go to the > target. We must only mirror chunks of data that are aligned to the > job's granularity, because that is how the dirty bitmap works. > Therefore, the request alignment for writes must be the job's > granularity (in write-blocking mode). > > Unfortunately, this forces all reads and writes to have the same > granularity (we only need this alignment for writes to the target, not > the source), but that is something to be fixed another time. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > v3: Handle bdrv_refresh_limits() errors [Vladimir] > --- > block/mirror.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+)
Thanks for the review, I’m taking the silence around “fix unaligned reset” as a sign to take this patch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block Max
signature.asc
Description: OpenPGP digital signature
