Hi Paolo, On 7/12/19 7:31 PM, Paolo Bonzini wrote: > On 12/07/19 18:45, Philippe Mathieu-Daudé wrote: >> On 7/12/19 4:58 PM, Paolo Bonzini wrote: >>> The other is whether we want to enable USB_BLUETOOTH by default. I >>> wouldn't have any problem there, but if we disable it basically no one >>> would ship/use it and we might as well delete the whole thing. >> >> The only user is the ARM Nokia N-series board, so if we set default=n, >> the Bluetooth subsystem will be only be selected on arm-softmmu (and >> aarch64-softmmu).
Using (1): + default y if BLUETOOTH depends on USB + select BLUETOOTH I get: KconfigDataError: cycle found including BLUETOOTH This works but doesn't follow kconfig.rst (2): + default y if BLUETOOTH depends on USB This works (kconfig.rst compliant, 3): + default n depends on USB + select BLUETOOTH Are you OK with (2) or you prefer (3)? >> >> This seems a sane cleanup. If another board wants to use the bluetooth >> code, it should probably move it out of the orphan status. > > Fair! ;) > > Paolo >