On Tue, Jun 25, 2019 at 07:08:25PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 25, 2019 at 02:00:06AM -0300, Eduardo Habkost wrote: > > Base code for versioned CPU models. This will register a "-4.1" > > version of all existing CPU models, and make the unversioned CPU > > models be an alias for the -4.1 versions on the pc-*-4.1 machine > > types. > > Currently we have some CPUs that I'd consider historical "mistakes" > due to fact that versioning didn't previously exist. > > eg > > Haswell > Haswell-noTSX > Haswell-noTSX-IBRS > > IIUC this patch adds > > Haswell alias-of Haswell-4.1 > Haswell-noTSX alias-of Haswell-noTSX-4.1 > Haswell-noTSX-IBRS alias-of Haswell-noTSX-IBRS-4.1 > > I'm thinking we should instead be merging all these haswell variants > > > Haswell alias-of Haswell-4.1.1 > Haswell-noTSX alias-of Haswell-4.1.2 > Haswell-noTSX-IBRS alias-of Haswell-4.1.3 > > Or if we used the simple counter versioning > > Haswell alias-of Haswell-1 > Haswell-noTSX alias-of Haswell-2 > Haswell-noTSX-IBRS alias-of Haswell-3 > > Likewise for the other named CPUs with wierd variants. > > This would effectively be "deprecating" the noTSX and IBRS variants > in favour of using the versioning approach
Sounds good. I will do it. -- Eduardo